Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gardena] Eliminate frequent web service re-starting #13238

Merged
merged 3 commits into from
Aug 12, 2022
Merged

[gardena] Eliminate frequent web service re-starting #13238

merged 3 commits into from
Aug 12, 2022

Conversation

gerrieg
Copy link
Contributor

@gerrieg gerrieg commented Aug 9, 2022

The connection tracker does not start after some websocket connections are disconnected. Therefore, every 2 minutes some API requests are sent to Gardena. This can lead to the message 429 limit exceeded after a few days/weeks.

gerrieg added 2 commits August 9, 2022 08:41
@gerrieg
Removed provider header, no longer necessary
498ed4e 
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
@gerrieg
Fixed connection tracker not starting after some websocket restarts
dc65f91 
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
@jlaur jlaur requested a review from andrewfg August 9, 2022 06:59
@andrewfg
Copy link
Contributor

andrewfg commented Aug 9, 2022

@gerrieg is this PR related to this post on the forum?

https://community.openhab.org/t/gardena-error-429-limit-exceeded/137419/62?u=andrewfg

@gerrieg
Copy link
Contributor Author

gerrieg commented Aug 9, 2022

yes exactly, this pull request should fix that

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Aug 9, 2022
@gerrieg
Removed explicit setting of the connection tracker to null
d82163e 
Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
@lolodomo
Copy link
Contributor

I am ok to merge the PR as it is, except if someone still thinks cancel should no be called with true as parameter.
The timing is now very short if we want to include this fix in 3.4M1.
I will merge it in the middle of the afternoon if noone reacts.

@lolodomo lolodomo merged commit 2d53243 into openhab:main Aug 12, 2022
@lolodomo lolodomo added this to the 3.4 milestone Aug 12, 2022
@andrewfg
Copy link
Contributor

except if someone still thinks cancel should no be called with true as parameter

No problem with that. But the task method should be synchronized..

@andrewfg andrewfg mentioned this pull request Aug 12, 2022
Merged
@andrewfg
Copy link
Contributor

@lolodomo you need to merge #13253 as well

@jlaur
Copy link
Contributor

jlaur commented Aug 12, 2022

@gerrieg, @andrewfg - can you of you change the PR title so it reflects the change from user-perspective? The title will be part of the release notes, and I don't think users will understand what connection tracker is. Alternatively remove the bug label if this fix is something additional for another PR already merged into 3.4, thus already covered in release notes?

@andrewfg andrewfg changed the title [gardena] Fixed connection tracker [gardena] Eliminate frequent web service re-starting Aug 12, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@gerrieg @leifbladt
[gardena] Fixed connection tracker (openhab#13238)
79dc5ca 
* Removed provider header, no longer necessary
* Fixed connection tracker not starting after some websocket restarts

Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@gerrieg @andan67
[gardena] Fixed connection tracker (openhab#13238)
6fe34d0 
* Removed provider header, no longer necessary
* Fixed connection tracker not starting after some websocket restarts

Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@gerrieg @andrasU
[gardena] Fixed connection tracker (openhab#13238)
8946e96 
* Removed provider header, no longer necessary
* Fixed connection tracker not starting after some websocket restarts

Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@gerrieg @psmedley
[gardena] Fixed connection tracker (openhab#13238)
0ad442a 
* Removed provider header, no longer necessary
* Fixed connection tracker not starting after some websocket restarts

Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@gerrieg @nemerdaud
[gardena] Fixed connection tracker (openhab#13238)
6db9309 
* Removed provider header, no longer necessary
* Fixed connection tracker not starting after some websocket restarts

Signed-off-by: Gerhard Riegler <gerhard.riegler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur left review comments

@andrewfg andrewfg andrewfg requested changes

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@gerrieg @andrewfg @lolodomo @jlaur